Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 72
Browse files Browse the repository at this point in the history
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 7.4.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: #26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
ryzokuken authored and refack committed Mar 28, 2019
1 parent 5613277 commit 7df9e77
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,11 @@
* V8 7.0: 67
* V8 7.1: 68
* V8 7.3: 71
* V8 7.4: 72
*
* More information can be found at https://nodejs.org/en/download/releases/
*/
#define NODE_MODULE_VERSION 71
#define NODE_MODULE_VERSION 72

// the NAPI_VERSION provided by this version of the runtime
#define NAPI_VERSION 4
Expand Down

0 comments on commit 7df9e77

Please sign in to comment.