From 7e08ccad17d95d866ca1177b6cc5711a6e8fea8d Mon Sep 17 00:00:00 2001
From: Colin Ihrig <cjihrig@gmail.com>
Date: Sat, 4 Jan 2025 12:18:49 -0500
Subject: [PATCH] test: update test-child-process-windows-hide to use node:test

This commit updates test/parallel/test-child-process-windows-hide.js
to use node:test. This allows the test to use the built in mocking
functionality instead of managing spies manually. It also prevents
multiple child processes from being spawned in parallel, which can
be problematic in the CI.

PR-URL: https://github.com/nodejs/node/pull/56437
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 .../test-child-process-windows-hide.js        | 47 +++++++++----------
 1 file changed, 23 insertions(+), 24 deletions(-)

diff --git a/test/parallel/test-child-process-windows-hide.js b/test/parallel/test-child-process-windows-hide.js
index ef4a8be8784ebc..c218c901a7f2ea 100644
--- a/test/parallel/test-child-process-windows-hide.js
+++ b/test/parallel/test-child-process-windows-hide.js
@@ -3,49 +3,48 @@
 const common = require('../common');
 const assert = require('assert');
 const cp = require('child_process');
+const { test } = require('node:test');
 const internalCp = require('internal/child_process');
 const cmd = process.execPath;
 const args = ['-p', '42'];
 const options = { windowsHide: true };
 
-// Since windowsHide isn't really observable, monkey patch spawn() and
-// spawnSync() to verify that the flag is being passed through correctly.
-const originalSpawn = internalCp.ChildProcess.prototype.spawn;
-const originalSpawnSync = internalCp.spawnSync;
+// Since windowsHide isn't really observable, this test relies on monkey
+// patching spawn() and spawnSync() to verify that the flag is being passed
+// through correctly.
 
-internalCp.ChildProcess.prototype.spawn = common.mustCall(function(options) {
-  assert.strictEqual(options.windowsHide, true);
-  return originalSpawn.apply(this, arguments);
-}, 2);
-
-internalCp.spawnSync = common.mustCall(function(options) {
-  assert.strictEqual(options.windowsHide, true);
-  return originalSpawnSync.apply(this, arguments);
-});
-
-{
+test('spawnSync() passes windowsHide correctly', (t) => {
+  const spy = t.mock.method(internalCp, 'spawnSync');
   const child = cp.spawnSync(cmd, args, options);
 
   assert.strictEqual(child.status, 0);
   assert.strictEqual(child.signal, null);
   assert.strictEqual(child.stdout.toString().trim(), '42');
   assert.strictEqual(child.stderr.toString().trim(), '');
-}
+  assert.strictEqual(spy.mock.calls.length, 1);
+  assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
+});
 
-{
+test('spawn() passes windowsHide correctly', (t, done) => {
+  const spy = t.mock.method(internalCp.ChildProcess.prototype, 'spawn');
   const child = cp.spawn(cmd, args, options);
 
   child.on('exit', common.mustCall((code, signal) => {
     assert.strictEqual(code, 0);
     assert.strictEqual(signal, null);
+    assert.strictEqual(spy.mock.calls.length, 1);
+    assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
+    done();
   }));
-}
+});
 
-{
-  const callback = common.mustSucceed((stdout, stderr) => {
+test('execFile() passes windowsHide correctly', (t, done) => {
+  const spy = t.mock.method(internalCp.ChildProcess.prototype, 'spawn');
+  cp.execFile(cmd, args, options, common.mustSucceed((stdout, stderr) => {
     assert.strictEqual(stdout.trim(), '42');
     assert.strictEqual(stderr.trim(), '');
-  });
-
-  cp.execFile(cmd, args, options, callback);
-}
+    assert.strictEqual(spy.mock.calls.length, 1);
+    assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
+    done();
+  }));
+});