From 7ead9af0f5f8cd51b7e1e93d164f8372c0da9aa6 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Tue, 8 Jan 2019 13:50:45 +0100 Subject: [PATCH] build: add check for empty openssl-fips flag Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: https://github.com/nodejs/node/pull/25391 Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Ruben Bridgewater --- configure.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.py b/configure.py index 531c6388017903..9766036b0260d0 100755 --- a/configure.py +++ b/configure.py @@ -1240,7 +1240,7 @@ def without_ssl_error(option): if options.openssl_no_asm and options.shared_openssl: error('--openssl-no-asm is incompatible with --shared-openssl') - if options.openssl_fips: + if options.openssl_fips or options.openssl_fips == '': error('FIPS is not supported in this version of Node.js') configure_library('openssl', o)