Skip to content

Commit

Permalink
lib: update TODO comments
Browse files Browse the repository at this point in the history
This removes one TODO comment and adds another that indicates that
readline is currently not able to trigger specific escape sequences.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33361
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
  • Loading branch information
BridgeAR authored and codebytere committed Jul 6, 2020
1 parent dfa8028 commit 83c9364
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 5 additions & 1 deletion lib/readline.js
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,8 @@ Interface.prototype._ttyWrite = function(s, key) {
if (key.ctrl && key.shift) {
/* Control and shift pressed */
switch (key.name) {
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
// identical to <ctrl>-h. It should have a unique escape sequence.
case 'backspace':
this._deleteLineLeft();
break;
Expand Down Expand Up @@ -945,8 +947,10 @@ Interface.prototype._ttyWrite = function(s, key) {
}
break;

// TODO(BridgeAR): This seems broken?
case 'w': // Delete backwards to a word boundary
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
// identical to <ctrl>-h. It should have a unique escape sequence.
// Falls through
case 'backspace':
this._deleteWordLeft();
break;
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-assert-deep.js
Original file line number Diff line number Diff line change
Expand Up @@ -958,8 +958,6 @@ assertDeepAndStrictEqual(obj1, obj2);

// Check proxies.
{
// TODO(BridgeAR): Check if it would not be better to detect proxies instead
// of just using the proxy value.
const arrProxy = new Proxy([1, 2], {});
assert.deepStrictEqual(arrProxy, [1, 2]);
const tmp = util.inspect.defaultOptions;
Expand Down

0 comments on commit 83c9364

Please sign in to comment.