Skip to content

Commit

Permalink
stream: fix fd is null when calling clearBuffer
Browse files Browse the repository at this point in the history
PR-URL: #50994
Fixes: #50979
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
kylo5aby authored and richardlau committed Mar 25, 2024
1 parent bd528c7 commit 8750070
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/internal/streams/writable.js
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,8 @@ function errorBuffer(state) {

// If there's something in the buffer waiting, then process it.
function clearBuffer(stream, state) {
if ((state[kState] & (kDestroyed | kBufferProcessing | kCorked | kBuffered)) !== kBuffered) {
if ((state[kState] & (kDestroyed | kBufferProcessing | kCorked | kBuffered | kConstructed)) !==
(kBuffered | kConstructed)) {
return;
}

Expand Down
28 changes: 28 additions & 0 deletions test/parallel/test-file-write-stream5.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
'use strict';

// Test 'uncork' for WritableStream.
// Refs: https://github.com/nodejs/node/issues/50979

const common = require('../common');
const fs = require('fs');
const assert = require('assert');
const test = require('node:test');
const tmpdir = require('../common/tmpdir');

const filepath = tmpdir.resolve('write_stream.txt');
tmpdir.refresh();

const data = 'data';

test('writable stream uncork', () => {
const fileWriteStream = fs.createWriteStream(filepath);

fileWriteStream.on('finish', common.mustCall(() => {
const writtenData = fs.readFileSync(filepath, 'utf8');
assert.strictEqual(writtenData, data);
}));
fileWriteStream.cork();
fileWriteStream.write(data, common.mustCall());
fileWriteStream.uncork();
fileWriteStream.end();
});

0 comments on commit 8750070

Please sign in to comment.