lib: refactor to use min/max of validateNumber

Fix NumberIsNaN is called two times and change error code to ERR_OUT_OF_RANGE when RangeError is occurred in test.
nodejs · Dec 7, 2022 · 89113b8 · 89113b8
1 parent 3bef549
commit 89113b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/lib/internal/histogram.js b/lib/internal/histogram.js
@@ -2,7 +2,6 @@
 
 const {
   MapPrototypeEntries,
-  NumberIsNaN,
   NumberIsInteger,
   NumberMAX_SAFE_INTEGER,
   ObjectFromEntries,
@@ -186,10 +185,7 @@ class Histogram {
   percentile(percentile) {
     if (!isHistogram(this))
       throw new ERR_INVALID_THIS('Histogram');
-    validateNumber(percentile, 'percentile');
-
-    if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100)
-      throw new ERR_INVALID_ARG_VALUE.RangeError('percentile', percentile);
+    validateNumber(percentile, 'percentile', 1, 100);
 
     return this[kHandle]?.percentile(percentile);
   }
@@ -201,10 +197,7 @@ class Histogram {
   percentileBigInt(percentile) {
     if (!isHistogram(this))
       throw new ERR_INVALID_THIS('Histogram');
-    validateNumber(percentile, 'percentile');
-
-    if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100)
-      throw new ERR_INVALID_ARG_VALUE.RangeError('percentile', percentile);
+    validateNumber(percentile, 'percentile', 1, 100);
 
     return this[kHandle]?.percentileBigInt(percentile);
   }

diff --git a/test/sequential/test-performance-eventloopdelay.js b/test/sequential/test-performance-eventloopdelay.js
@@ -91,7 +91,7 @@ const { sleep } = require('internal/util');
           () => histogram.percentile(i),
           {
             name: 'RangeError',
-            code: 'ERR_INVALID_ARG_VALUE'
+            code: 'ERR_OUT_OF_RANGE'
           }
         );
       });