Skip to content

Commit

Permalink
lib: remove lib/internal/idna.js
Browse files Browse the repository at this point in the history
PR-URL: #55050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
  • Loading branch information
anonrig authored and marco-ippolito committed Nov 17, 2024
1 parent 2f678ea commit 8e6b606
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions lib/internal/idna.js

This file was deleted.

2 changes: 1 addition & 1 deletion lib/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const {
decodeURIComponent,
} = primordials;

const { toASCII } = require('internal/idna');
const { toASCII } = internalBinding('encoding_binding');
const { encodeStr, hexTable } = require('internal/querystring');
const querystring = require('querystring');

Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-bootstrap-modules.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ expected.atRunTime = new Set([

if (common.isMainThread) {
[
'NativeModule internal/idna',
'NativeModule url',
].forEach(expected.beforePreExec.add.bind(expected.beforePreExec));
} else { // Worker.
Expand Down

0 comments on commit 8e6b606

Please sign in to comment.