From 8e6b606ac45f43548b6c843e57bfcc7633c5fbc3 Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Mon, 23 Sep 2024 15:33:43 -0400 Subject: [PATCH] lib: remove lib/internal/idna.js PR-URL: https://github.com/nodejs/node/pull/55050 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Chemi Atlow --- lib/internal/idna.js | 4 ---- lib/url.js | 2 +- test/parallel/test-bootstrap-modules.js | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) delete mode 100644 lib/internal/idna.js diff --git a/lib/internal/idna.js b/lib/internal/idna.js deleted file mode 100644 index ad37bb48efc605..00000000000000 --- a/lib/internal/idna.js +++ /dev/null @@ -1,4 +0,0 @@ -'use strict'; - -const { toASCII, toUnicode } = internalBinding('encoding_binding'); -module.exports = { toASCII, toUnicode }; diff --git a/lib/url.js b/lib/url.js index 8fa8553c2b3f30..a2dc57e8bd24e4 100644 --- a/lib/url.js +++ b/lib/url.js @@ -30,7 +30,7 @@ const { decodeURIComponent, } = primordials; -const { toASCII } = require('internal/idna'); +const { toASCII } = internalBinding('encoding_binding'); const { encodeStr, hexTable } = require('internal/querystring'); const querystring = require('querystring'); diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js index 76366cf2c8604d..0c2831c4780574 100644 --- a/test/parallel/test-bootstrap-modules.js +++ b/test/parallel/test-bootstrap-modules.js @@ -113,7 +113,6 @@ expected.atRunTime = new Set([ if (common.isMainThread) { [ - 'NativeModule internal/idna', 'NativeModule url', ].forEach(expected.beforePreExec.add.bind(expected.beforePreExec)); } else { // Worker.