From 928805bb22bb46ebf41c7c1890a6d7bda65ba7db Mon Sep 17 00:00:00 2001 From: James Kylstra Date: Fri, 8 Jun 2018 08:13:09 -0500 Subject: [PATCH] test: remove string literals from assert.strictEqual() calls In test/parallel/test-intl.js, five calls to assert.strictEqual() use a third, string-literal parameter, which specifies a message to display when the assertion fails. The problem is that if the assertion fails, the error message will show the string literal but not the values that caused the assertion to fail. This commit removes the third parameter from the five calls and makes them comments above the assertions instead. The default error message produced by assert.strictEqual() shows the values that caused the assertion to fail, which should be somewhat more helpful. PR-URL: https://github.com/nodejs/node/pull/21211 Reviewed-By: James M Snell Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat --- test/parallel/test-intl.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/test/parallel/test-intl.js b/test/parallel/test-intl.js index a1aea88aaddd92..618e8c49bce03f 100644 --- a/test/parallel/test-intl.js +++ b/test/parallel/test-intl.js @@ -105,14 +105,14 @@ if (!common.hasIntl) { const collOpts = { sensitivity: 'base', ignorePunctuation: true }; const coll = new Intl.Collator(['en'], collOpts); - assert.strictEqual(coll.compare('blackbird', 'black-bird'), 0, - 'ignore punctuation failed'); - assert.strictEqual(coll.compare('blackbird', 'red-bird'), -1, - 'compare less failed'); - assert.strictEqual(coll.compare('bluebird', 'blackbird'), 1, - 'compare greater failed'); - assert.strictEqual(coll.compare('Bluebird', 'bluebird'), 0, - 'ignore case failed'); - assert.strictEqual(coll.compare('\ufb03', 'ffi'), 0, - 'ffi ligature (contraction) failed'); + // ignore punctuation + assert.strictEqual(coll.compare('blackbird', 'black-bird'), 0); + // compare less + assert.strictEqual(coll.compare('blackbird', 'red-bird'), -1); + // compare greater + assert.strictEqual(coll.compare('bluebird', 'blackbird'), 1); + // ignore case + assert.strictEqual(coll.compare('Bluebird', 'bluebird'), 0); + // ffi ligature (contraction) + assert.strictEqual(coll.compare('\ufb03', 'ffi'), 0); }