From 95a95cced3a7413ff76906c2a2021599a274dcc0 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 23 Jul 2017 15:31:19 -0700 Subject: [PATCH] test: fix flaky test-force-repl test/parallel/test-force-repl.js has an unnecessary timer that makes the test flaky under load. Remove it. PR-URL: https://github.com/nodejs/node/pull/14439 Reviewed-By: Gibson Fahnestock Reviewed-By: Refael Ackermann Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen --- test/parallel/test-force-repl.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-force-repl.js b/test/parallel/test-force-repl.js index 03246d269d7765..15475a7e30ed8d 100644 --- a/test/parallel/test-force-repl.js +++ b/test/parallel/test-force-repl.js @@ -3,16 +3,13 @@ const common = require('../common'); const assert = require('assert'); const spawn = require('child_process').spawn; -// spawn a node child process in "interactive" mode (force the repl) +// Spawn a node child process in interactive mode (enabling the REPL) and +// confirm the '> ' prompt is included in the output. const cp = spawn(process.execPath, ['-i']); -// give node + the repl 5 seconds to start -const timeoutId = setTimeout(common.mustNotCall(), - common.platformTimeout(5000)); cp.stdout.setEncoding('utf8'); cp.stdout.once('data', common.mustCall(function(b) { - clearTimeout(timeoutId); assert.strictEqual(b, '> '); cp.kill(); }));