Skip to content

Commit

Permalink
deps: always define V8_NODISCARD as no-op
Browse files Browse the repository at this point in the history
It's causing compiler errors with some classes on Xcode 11
and the attribute should have no runtime effect.

PR-URL: #54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
targos authored and nodejs-github-bot committed Sep 19, 2024
1 parent 09d997f commit 95f2213
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.5',
'v8_embedder_string': '-node.6',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/include/v8config.h
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ path. Add it with -I<path> to the command line
// V8_NODISCARD Foo() { ... };
// [[nodiscard]] comes in C++17 but supported in clang with -std >= c++11.
#if V8_HAS_CPP_ATTRIBUTE_NODISCARD
#define V8_NODISCARD [[nodiscard]]
#define V8_NODISCARD
#else
#define V8_NODISCARD /* NOT SUPPORTED */
#endif
Expand Down

0 comments on commit 95f2213

Please sign in to comment.