Skip to content

Commit

Permalink
doc: remove extra using v8::HandleScope statement
Browse files Browse the repository at this point in the history
v8::HandleScope does not seem to be required for addon functions.

PR-URL: #2983
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
Christopher J. Brody authored and rvagg committed Sep 22, 2015
1 parent f010cb5 commit 9c59d2f
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions doc/api/addons.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ First we create a file `hello.cc`:
namespace demo {

using v8::FunctionCallbackInfo;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Object;
Expand Down Expand Up @@ -155,7 +154,6 @@ function calls and return a result. This is the main and only needed source

using v8::Exception;
using v8::FunctionCallbackInfo;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Number;
Expand Down Expand Up @@ -212,7 +210,6 @@ there. Here's `addon.cc`:

using v8::Function;
using v8::FunctionCallbackInfo;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Null;
Expand Down Expand Up @@ -263,7 +260,6 @@ the string passed to `createObject()`:
namespace demo {

using v8::FunctionCallbackInfo;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Object;
Expand Down Expand Up @@ -310,7 +306,6 @@ wraps a C++ function:
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Object;
Expand Down Expand Up @@ -415,7 +410,6 @@ prototype:
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Number;
Expand Down Expand Up @@ -505,7 +499,6 @@ Let's register our `createObject` method in `addon.cc`:
namespace demo {

using v8::FunctionCallbackInfo;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Object;
Expand Down Expand Up @@ -568,7 +561,6 @@ The implementation is similar to the above in `myobject.cc`:
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Number;
Expand Down Expand Up @@ -668,7 +660,6 @@ In the following `addon.cc` we introduce a function `add()` that can take on two
namespace demo {

using v8::FunctionCallbackInfo;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Number;
Expand Down Expand Up @@ -745,7 +736,6 @@ The implementation of `myobject.cc` is similar as before:
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::Object;
Expand Down

0 comments on commit 9c59d2f

Please sign in to comment.