Skip to content

Commit

Permalink
deps: no /safeseh for ml64.exe
Browse files Browse the repository at this point in the history
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
  • Loading branch information
indutny authored and MylesBorins committed Oct 26, 2016
1 parent ea36c61 commit 9ddc615
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions deps/openssl/openssl.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,17 @@
}], # end of conditions of openssl_no_asm
['OS=="win"', {
'defines' : ['<@(openssl_defines_all_win)'],
}, {
'defines' : ['<@(openssl_defines_all_non_win)']
}],
['target_arch=="ia32" and OS=="win"', {
'msvs_settings': {
'MASM': {
# Use /safeseh, see commit: 01fa5ee
'UseSafeExceptionHandlers': 'true',
},
},
}, {
'defines' : ['<@(openssl_defines_all_non_win)']
}]
}],
],
'include_dirs': ['<@(openssl_include_dirs)'],
'direct_dependent_settings': {
Expand Down

0 comments on commit 9ddc615

Please sign in to comment.