From 9e1dcdc5bd9cd7128c61e8c721fc8ae9d97c272c Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 27 Apr 2018 00:16:09 +0200 Subject: [PATCH] src: remove NodeCategorySet destructor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This currently crashes during environment cleanup because the object would be torn down while there are enabled categories. I’m not sure about the exact semantics here, but since the object cannot be garbage collected at this point anyway because it’s `Persistent` handle is strong, removing the destructor at least doesn’t make anything worse than it is right now (i.e. the destructor would never have been called before anyway). PR-URL: https://github.com/nodejs/node/pull/19377 Reviewed-By: Ben Noordhuis Reviewed-By: James M Snell --- src/node_trace_events.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc index 0c0699f7be9e1f..363d046de1e947 100644 --- a/src/node_trace_events.cc +++ b/src/node_trace_events.cc @@ -21,11 +21,6 @@ using v8::Value; class NodeCategorySet : public BaseObject { public: - ~NodeCategorySet() override { - // Verify that the thing was properly disabled before gc - CHECK_NE(enabled_, true); - } - static void New(const FunctionCallbackInfo& args); static void Enable(const FunctionCallbackInfo& args); static void Disable(const FunctionCallbackInfo& args);