From 9f87d6ad4d71643f9b1bafcf4d6e4047ab4f61a9 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 25 Oct 2017 12:36:24 +0200 Subject: [PATCH] test: call toLowerCase on the resolved module The commit updates test-require-resolve.js to call toLowerCase on the resolved module instead of the path. Currently this test will fail if the path to where node exists contains uppercase letters. For example: ``` $ out/Release/node test/parallel/test-require-resolve.js /root/rpmbuild/BUILD/node-v8.8.0/test/parallel module.js:515 throw err; ^ Error: Cannot find module '/root/rpmbuild/build/node-v8.8.0/test/fixtures/nested-index/one' at Function.Module._resolveFilename (module.js:513:15) at Function.resolve (internal/module.js:18:19) at Object. (/root/rpmbuild/BUILD/node-v8.8.0/test/parallel/test-require-resolve.js:37:11) at Module._compile (module.js:612:30) at Object.Module._extensions..js (module.js:623:10) at Module.load (module.js:531:32) at tryModuleLoad (module.js:494:12) at Function.Module._load (module.js:486:3) at Function.Module.runMain (module.js:653:10) at startup (bootstrap_node.js:187:16) ``` PR-URL: https://github.com/nodejs/node/pull/16486 Reviewed-By: Luigi Pinca > Reviewed-By: Ben Noordhuis > Reviewed-By: Colin Ihrig > Reviewed-By: Anna Henningsen > Reviewed-By: James M Snell > --- test/parallel/test-require-resolve.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-require-resolve.js b/test/parallel/test-require-resolve.js index 77f07b394fcc64..b897936696d20d 100644 --- a/test/parallel/test-require-resolve.js +++ b/test/parallel/test-require-resolve.js @@ -32,7 +32,7 @@ assert.strictEqual( require.resolve(fixtures.path('a')).toLowerCase()); assert.strictEqual( fixtures.path('nested-index', 'one', 'index.js').toLowerCase(), - require.resolve(fixtures.path('nested-index', 'one').toLowerCase())); + require.resolve(fixtures.path('nested-index', 'one')).toLowerCase()); assert.strictEqual('path', require.resolve('path')); console.log('ok');