-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http: unref socket timer on parser execute
When underlying `net.Socket` instance is consumed in http server - no `data` events are emitted, and thus `socket.setTimeout` fires the callback even if the data is constantly flowing into the socket. Fix this by calling `socket._unrefTimer()` on every `onParserExecute` call. Fix: #5899 PR-URL: #6286 Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
2 changed files
with
37 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const http = require('http'); | ||
|
||
const server = http.createServer((req, res) => { | ||
server.close(); | ||
|
||
res.writeHead(200); | ||
res.flushHeaders(); | ||
|
||
req.setTimeout(common.platformTimeout(200), () => { | ||
assert(false, 'Should not happen'); | ||
}); | ||
req.resume(); | ||
req.once('end', common.mustCall(() => { | ||
res.end(); | ||
})); | ||
}); | ||
|
||
server.listen(common.PORT, common.mustCall(() => { | ||
const req = http.request({ | ||
port: common.PORT, | ||
method: 'POST' | ||
}, (res) => { | ||
const interval = setInterval(() => { | ||
req.write('a'); | ||
}, common.platformTimeout(25)); | ||
setTimeout(() => { | ||
clearInterval(interval); | ||
req.end(); | ||
}, common.platformTimeout(400)); | ||
}); | ||
req.write('.'); | ||
})); |