Skip to content

Commit

Permalink
tools: don't print gold linker warning w/o flag
Browse files Browse the repository at this point in the history
Currently warning is printed called even if the selection ordering flag
has not been passed.

Only print warning if `--limit-configure-section-file`
has been passed to configure.

Fixes: #35872

PR-URL: #35955
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
MylesBorins authored and danielleadams committed Nov 9, 2020
1 parent 1f27214 commit a7350b3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1761,7 +1761,8 @@ def configure_section_file(o):
proc = subprocess.Popen(['ld.gold'] + ['-v'], stdin = subprocess.PIPE,
stdout = subprocess.PIPE, stderr = subprocess.PIPE)
except OSError:
warn('''No acceptable ld.gold linker found!''')
if options.node_section_ordering_info != "":
warn('''No acceptable ld.gold linker found!''')
return 0

match = re.match(r"^GNU gold.*([0-9]+)\.([0-9]+)$",
Expand Down

0 comments on commit a7350b3

Please sign in to comment.