From a8a75754100573e0a16884c6e74141011868fceb Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Mon, 25 Jun 2018 19:19:41 +0200 Subject: [PATCH] src: remove extra `ReadStop()` call This is no longer necessary since libuv 1.21.0. PR-URL: https://github.com/nodejs/node/pull/21528 Reviewed-By: Gus Caplan Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- src/stream_wrap.cc | 5 ----- src/stream_wrap.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/src/stream_wrap.cc b/src/stream_wrap.cc index c35df11febb9d2..ddeb74d80970f0 100644 --- a/src/stream_wrap.cc +++ b/src/stream_wrap.cc @@ -373,11 +373,6 @@ void LibuvStreamWrap::AfterUvWrite(uv_write_t* req, int status) { req_wrap->Done(status); } -void LibuvStreamWrap::Close(v8::Local close_callback) { - ReadStop(); - HandleWrap::Close(close_callback); -} - } // namespace node NODE_BUILTIN_MODULE_CONTEXT_AWARE(stream_wrap, diff --git a/src/stream_wrap.h b/src/stream_wrap.h index 94a161b6d54e07..7847ebe754614a 100644 --- a/src/stream_wrap.h +++ b/src/stream_wrap.h @@ -76,8 +76,6 @@ class LibuvStreamWrap : public HandleWrap, public StreamBase { ShutdownWrap* CreateShutdownWrap(v8::Local object) override; WriteWrap* CreateWriteWrap(v8::Local object) override; - void Close(v8::Local close_callback) override; - protected: LibuvStreamWrap(Environment* env, v8::Local object,