Skip to content

Commit

Permalink
test: url format path ending hashchar not covered
Browse files Browse the repository at this point in the history
PR-URL: #24259
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
ovhemert authored and codebytere committed Jan 12, 2019
1 parent 9970d56 commit aba7b47
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions test/parallel/test-url-format.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,16 @@ const formatTests = {
hash: '#bar'
},

// `#` in path end + `#` in query
'/path/to/%%23?foo=the%231#bar': {
href: '/path/to/%%23?foo=the%231#bar',
pathname: '/path/to/%#',
query: {
foo: 'the#1'
},
hash: '#bar'
},

// `?` and `#` in path and search
'http://ex.com/foo%3F100%m%23r?abc=the%231?&foo=bar#frag': {
href: 'http://ex.com/foo%3F100%m%23r?abc=the%231?&foo=bar#frag',
Expand Down

0 comments on commit aba7b47

Please sign in to comment.