src: register external references in os bindings

PR-URL: #40239 Refs: #38905 Refs: #37476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Oct 23, 2021 · accab38 · accab38
1 parent a11f9ea
commit accab38
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -32,7 +32,6 @@ namespace node {
 using v8::Context;
 using v8::Local;
 using v8::Object;
-using v8::TryCatch;
 using v8::Value;
 
 namespace crypto {

diff --git a/src/node_external_reference.h b/src/node_external_reference.h
@@ -62,6 +62,7 @@ class ExternalReferenceRegistry {
   V(heap_utils)                                                                \
   V(messaging)                                                                 \
   V(native_module)                                                             \
+  V(os)                                                                        \
   V(performance)                                                               \
   V(process_methods)                                                           \
   V(process_object)                                                            \

diff --git a/src/node_os.cc b/src/node_os.cc
@@ -20,6 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 #include "env-inl.h"
+#include "node_external_reference.h"
 #include "string_bytes.h"
 
 #ifdef __MINGW32__
@@ -398,7 +399,23 @@ void Initialize(Local<Object> target,
               Boolean::New(env->isolate(), IsBigEndian())).Check();
 }
 
+void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
+  registry->Register(GetHostname);
+  registry->Register(GetLoadAvg);
+  registry->Register(GetUptime);
+  registry->Register(GetTotalMemory);
+  registry->Register(GetFreeMemory);
+  registry->Register(GetCPUInfo);
+  registry->Register(GetInterfaceAddresses);
+  registry->Register(GetHomeDirectory);
+  registry->Register(GetUserInfo);
+  registry->Register(SetPriority);
+  registry->Register(GetPriority);
+  registry->Register(GetOSInformation);
+}
+
 }  // namespace os
 }  // namespace node
 
 NODE_MODULE_CONTEXT_AWARE_INTERNAL(os, node::os::Initialize)
+NODE_MODULE_EXTERNAL_REFERENCE(os, node::os::RegisterExternalReferences)