Skip to content

Commit

Permalink
test: skip pseudo-tty/no_dropped_stdio test
Browse files Browse the repository at this point in the history
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
mhdawson authored and MylesBorins committed Oct 26, 2016
1 parent 6d03170 commit ad1230e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion test/pseudo-tty/pseudo-tty.status
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
prefix pseudo-tty

[$system==aix]
# test issue only, covered under https://github.com/nodejs/node/issues/7973
no_dropped_stdio : PASS, FLAKY
no_dropped_stdio : SKIP
2 changes: 1 addition & 1 deletion test/pseudo-tty/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def GetBuildRequirements(self):
return ['sample', 'sample=shell']

def GetTestStatus(self, sections, defs):
status_file = join(self.root, 'message.status')
status_file = join(self.root, 'pseudo-tty.status')
if exists(status_file):
test.ReadConfigurationInto(status_file, sections, defs)

Expand Down

0 comments on commit ad1230e

Please sign in to comment.