util: move util.isDate to eol

PR-URL: #52744 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · May 6, 2024 · b5cae4f · b5cae4f
1 parent bd559e3
commit b5cae4f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 41 deletions.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -1050,6 +1050,9 @@ The `util.isBuffer()` API has been removed. Please use
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/52744
+    description: End-of-Life deprecation.
   - version: v22.0.0
     pr-url: https://github.com/nodejs/node/pull/50488
     description: Runtime deprecation.
@@ -1065,9 +1068,9 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
-The [`util.isDate()`][] API is deprecated. Please use
+The `util.isDate()` API has been removed. Please use
 `arg instanceof Date` instead.
 
 ### DEP0048: `util.isError()`

diff --git a/doc/api/util.md b/doc/api/util.md
@@ -2950,31 +2950,6 @@ util.isArray({});
 // Returns: false
 ```
 
-### `util.isDate(object)`
-
-<!-- YAML
-added: v0.6.0
-deprecated: v4.0.0
--->
-
-> Stability: 0 - Deprecated: Use [`util.types.isDate()`][] instead.
-
-* `object` {any}
-* Returns: {boolean}
-
-Returns `true` if the given `object` is a `Date`. Otherwise, returns `false`.
-
-```js
-const util = require('node:util');
-
-util.isDate(new Date());
-// Returns: true
-util.isDate(Date());
-// false (without 'new' returns a String)
-util.isDate({});
-// Returns: false
-```
-
 ### `util.isError(object)`
 
 <!-- YAML
@@ -3152,7 +3127,6 @@ util.log('Timestamped message.');
 [`util.promisify()`]: #utilpromisifyoriginal
 [`util.types.isAnyArrayBuffer()`]: #utiltypesisanyarraybuffervalue
 [`util.types.isArrayBuffer()`]: #utiltypesisarraybuffervalue
-[`util.types.isDate()`]: #utiltypesisdatevalue
 [`util.types.isNativeError()`]: #utiltypesisnativeerrorvalue
 [`util.types.isSharedArrayBuffer()`]: #utiltypesissharedarraybuffervalue
 [async function]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function

diff --git a/lib/util.js b/lib/util.js
@@ -354,9 +354,6 @@ module.exports = {
     }
     return internalDeepEqual(a, b);
   },
-  isDate: deprecate(types.isDate,
-                    'The `util.isDate` API is deprecated.  Please use `arg instanceof Date` instead.',
-                    'DEP0047'),
   isError: deprecate(isError,
                      'The `util.isError` API is deprecated. ' +
                      'Please use `ObjectPrototypeToString(e) === "[object Error]" ' +

diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
@@ -40,16 +40,6 @@ assert.strictEqual(util.isArray(/regexp/), false);
 assert.strictEqual(util.isArray(new Error()), false);
 assert.strictEqual(util.isArray({ __proto__: Array.prototype }), false);
 
-// isDate
-assert.strictEqual(util.isDate(new Date()), true);
-assert.strictEqual(util.isDate(new Date(0), 'foo'), true);
-assert.strictEqual(util.isDate(new (context('Date'))()), true);
-assert.strictEqual(util.isDate(Date()), false);
-assert.strictEqual(util.isDate({}), false);
-assert.strictEqual(util.isDate([]), false);
-assert.strictEqual(util.isDate(new Error()), false);
-assert.strictEqual(util.isDate({ __proto__: Date.prototype }), false);
-
 // isError
 assert.strictEqual(util.isError(new Error()), true);
 assert.strictEqual(util.isError(new TypeError()), true);