From b8fe07df9b0e6c910cb28e90b9452565949bcfd9 Mon Sep 17 00:00:00 2001
From: Sanjaiyan Parthipan <parthipankalayini@gmail.com>
Date: Sat, 23 Dec 2023 06:21:47 +0530
Subject: [PATCH] lib: move function declaration outside of loop

PR-URL: https://github.com/nodejs/node/pull/51242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
---
 lib/internal/per_context/primordials.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib/internal/per_context/primordials.js b/lib/internal/per_context/primordials.js
index 5deea076755c9e..140c80566c9e6c 100644
--- a/lib/internal/per_context/primordials.js
+++ b/lib/internal/per_context/primordials.js
@@ -541,11 +541,14 @@ primordials.SafePromiseAllReturnVoid = (promises, mapFn) =>
   new Promise((resolve, reject) => {
     let pendingPromises = promises.length;
     if (pendingPromises === 0) resolve();
+    const onFulfilled = () => {
+      if (--pendingPromises === 0) {
+        resolve();
+      }
+    };
     for (let i = 0; i < promises.length; i++) {
       const promise = mapFn != null ? mapFn(promises[i], i) : promises[i];
-      PromisePrototypeThen(PromiseResolve(promise), () => {
-        if (--pendingPromises === 0) resolve();
-      }, reject);
+      PromisePrototypeThen(PromiseResolve(promise), onFulfilled, reject);
     }
   });