Skip to content

Commit

Permalink
test: fix order of arguments passed to strictEqual
Browse files Browse the repository at this point in the history
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: #23571
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
eojthebrave authored and MylesBorins committed Oct 30, 2018
1 parent 2a3ba01 commit bcf24e7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-net-socket-local-address.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ const server = net.createServer((socket) => {

server.on('close', common.mustCall(() => {
// client and server should agree on the ports used
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts);
assert.strictEqual(2, conns);
assert.deepStrictEqual(serverRemotePorts, clientLocalPorts);
assert.strictEqual(conns, 2);
}));

server.listen(0, common.localhostIPv4, connect);
Expand Down

0 comments on commit bcf24e7

Please sign in to comment.