From be9217267b821a2bff2e43c4ea17909b16a53a5e Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 20 Dec 2017 12:31:22 -0800 Subject: [PATCH] test: refactor test-repl-definecommand The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: https://github.com/nodejs/node/pull/17795 Reviewed-By: Jon Moss Reviewed-By: James M Snell --- test/parallel/test-repl-definecommand.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-repl-definecommand.js b/test/parallel/test-repl-definecommand.js index 80a06af6b077d2..2fac805222885d 100644 --- a/test/parallel/test-repl-definecommand.js +++ b/test/parallel/test-repl-definecommand.js @@ -23,14 +23,14 @@ r.defineCommand('say1', { help: 'help for say1', action: function(thing) { output = ''; - this.write(`hello ${thing}`); + this.output.write(`hello ${thing}\n`); this.displayPrompt(); } }); r.defineCommand('say2', function() { output = ''; - this.write('hello from say2'); + this.output.write('hello from say2\n'); this.displayPrompt(); }); @@ -38,6 +38,12 @@ inputStream.write('.help\n'); assert(/\n.say1 help for say1\n/.test(output), 'help for say1 not present'); assert(/\n.say2\n/.test(output), 'help for say2 not present'); inputStream.write('.say1 node developer\n'); -assert(/> hello node developer/.test(output), 'say1 outputted incorrectly'); +assert.ok(output.startsWith('hello node developer\n'), + `say1 output starts incorrectly: "${output}"`); +assert.ok(output.includes('> '), + `say1 output does not include prompt: "${output}"`); inputStream.write('.say2 node developer\n'); -assert(/> hello from say2/.test(output), 'say2 outputted incorrectly'); +assert.ok(output.startsWith('hello from say2\n'), + `say2 output starts incorrectly: "${output}"`); +assert.ok(output.includes('> '), + `say2 output does not include prompt: "${output}"`);