crypto: fix crypto.verify callback invocation with a private keyobject

fixes #37794 PR-URL: #37795 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs · Mar 20, 2021 · bfe3f21 · bfe3f21
1 parent 505f9c9
commit bfe3f21
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/crypto/crypto_sig.cc b/src/crypto/crypto_sig.cc
@@ -847,7 +847,7 @@ bool SignTraits::DeriveBits(
       }
       break;
     case SignConfiguration::kVerify:
-      CHECK_EQ(params.key->GetKeyType(), kKeyTypePublic);
+      CHECK_NE(params.key->GetKeyType(), kKeyTypeSecret);
       if (!EVP_DigestVerifyInit(
               context.get(),
               &ctx,

diff --git a/test/parallel/test-crypto-async-sign-verify.js b/test/parallel/test-crypto-async-sign-verify.js
@@ -52,7 +52,9 @@ function test(
     }));
   }
 
-  for (const key of [publicPem, publicKey, publicDer]) {
+  const verifyInputs = [
+    publicPem, publicKey, publicDer, privatePem, privateKey, privateDer];
+  for (const key of verifyInputs) {
     crypto.verify(algorithm, data, key, expected, common.mustSucceed(
       (verified) => assert.strictEqual(verified, true)));