From c0136d9b76b7b14894ed5da561a084eb8ed5ace0 Mon Sep 17 00:00:00 2001 From: Andrew J D McCann Date: Fri, 12 Oct 2018 10:31:06 -0700 Subject: [PATCH] src: use default initializers over settings fields on the constructor PR-URL: https://github.com/nodejs/node/pull/23532 Reviewed-By: James M Snell Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Trivikram Kamat Reviewed-By: Ruben Bridgewater --- src/spawn_sync.cc | 4 +--- src/spawn_sync.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc index 46d895e38a7389..d57b4b03e23394 100644 --- a/src/spawn_sync.cc +++ b/src/spawn_sync.cc @@ -50,9 +50,7 @@ using v8::String; using v8::Value; -SyncProcessOutputBuffer::SyncProcessOutputBuffer() - : used_(0), - next_(nullptr) { +SyncProcessOutputBuffer::SyncProcessOutputBuffer() { } diff --git a/src/spawn_sync.h b/src/spawn_sync.h index adb2618cc5f404..397e62b9d2c0d9 100644 --- a/src/spawn_sync.h +++ b/src/spawn_sync.h @@ -56,9 +56,9 @@ class SyncProcessOutputBuffer { private: // Use unsigned int because that's what `uv_buf_init` takes. mutable char data_[kBufferSize]; - unsigned int used_; + unsigned int used_ = 0; - SyncProcessOutputBuffer* next_; + SyncProcessOutputBuffer* next_ = nullptr; };