From c0f43bfda8f65f33e48892c2da86ff70eba63392 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sat, 11 Apr 2020 20:50:59 +0200 Subject: [PATCH] build: add configure flag to build V8 with DCHECKs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add a configure flag that enables building V8 with `-DDEBUG`, in particular with debug checks enabled and with runtime debugging features, e.g. inspecting JS objects from debuggers, enabled. PR-URL: https://github.com/nodejs/node/pull/32787 Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: Matheus Marchini Reviewed-By: Gireesh Punathil Reviewed-By: Jiawen Geng --- configure.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/configure.py b/configure.py index fed56260d8ae6c..2e7deb5a15ef11 100755 --- a/configure.py +++ b/configure.py @@ -635,6 +635,12 @@ default=False, help='compile V8 with minimal optimizations and with runtime checks') +parser.add_option('--v8-with-dchecks', + action='store_true', + dest='v8_with_dchecks', + default=False, + help='compile V8 with debug checks and runtime debugging features enabled') + parser.add_option('--node-builtin-modules-path', action='store', dest='node_builtin_modules_path', @@ -1235,6 +1241,7 @@ def configure_v8(o): o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0 o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs. o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1 + o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0 o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables. o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks. o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1