perf_hooks: ignore duplicated entries in observer

PerformanceObserver should add to observing only unique entry types. PR-URL: #29442 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
nodejs · Sep 20, 2019 · c146fff · c146fff
1 parent 9b4a49c
commit c146fff
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js
@@ -354,6 +354,7 @@ class PerformanceObserver extends AsyncResource {
     for (var n = 0; n < entryTypes.length; n++) {
       const entryType = entryTypes[n];
       const list = getObserversList(entryType);
+      if (this[kTypes][entryType]) continue;
       const item = { obs: this };
       this[kTypes][entryType] = item;
       L.append(list, item);

diff --git a/test/parallel/test-performanceobserver.js b/test/parallel/test-performanceobserver.js
@@ -62,6 +62,12 @@ assert.strictEqual(counts[NODE_PERFORMANCE_ENTRY_TYPE_FUNCTION], 0);
                                    'for option "entryTypes"'
                         });
   });
+
+  const obs = new PerformanceObserver(common.mustNotCall());
+  obs.observe({ entryTypes: ['mark', 'mark'] });
+  obs.disconnect();
+  performance.mark('42');
+  assert.strictEqual(counts[NODE_PERFORMANCE_ENTRY_TYPE_MARK], 0);
 }
 
 // Test Non-Buffered