From c2897656297edf9b6995aa9437eb44a0ff9a8ba2 Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Fri, 11 Aug 2023 19:42:16 -0300 Subject: [PATCH] doc: make the NODE_VERSION_IS_RELEASE revert clear --- doc/contributing/releases.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 00fd536c2a0a50..27907bdaeb7492 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -813,7 +813,9 @@ git commit --amend Even if there are no conflicts, ensure that you revert all the changes that were -made to `src/node_version.h`. +made to `src/node_version.h`. `NODE_VERSION_IS_RELEASE` must be `0`. + +Edit `src/node_version.h`, revert `NODE_VERSION_IS_RELEASE` back to `0`, and `git commit --amend` If there are conflicts in `doc` due to updated `REPLACEME` placeholders (that happens when a change previously landed on another release