From c535bde5da18d0fb8c30bf6a3f122fcd7a383662 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 15 Aug 2018 20:32:58 -0700 Subject: [PATCH] tools: simplify ESLint invocation in Makefile Makefile currently enforces .eslintrc.js linting on the command line but it is already enforced in the .estlintignore file. This also simplifies an arguably-related comment in .estlinrc.js. PR-URL: https://github.com/nodejs/node/pull/22348 Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Richard Lau Reviewed-By: Jon Moss Reviewed-By: Ruben Bridgewater Reviewed-By: Roman Reiss Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat --- .eslintrc.js | 2 +- Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index c2125133933ffc..9c3a78d81cd27a 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -187,7 +187,7 @@ module.exports = { message: 'Use new keyword when throwing an Error.', } ], - /* eslint-enable max-len, quotes */ + /* eslint-enable max-len */ 'no-return-await': 'error', 'no-self-assign': 'error', 'no-self-compare': 'error', diff --git a/Makefile b/Makefile index 231948c15b95bd..5a499b1a5aafe2 100644 --- a/Makefile +++ b/Makefile @@ -1120,7 +1120,7 @@ endif LINT_JS_TARGETS = .eslintrc.js benchmark doc lib test tools run-lint-js = tools/node_modules/eslint/bin/eslint.js --cache \ - --ext=.js,.mjs,.md $(LINT_JS_TARGETS) --ignore-pattern '!.eslintrc.js' + --ext=.js,.mjs,.md $(LINT_JS_TARGETS) run-lint-js-fix = $(run-lint-js) --fix .PHONY: lint-js-fix