From c7bd21cfff0f9c34a0f0f232cc3a0928ef9bc72a Mon Sep 17 00:00:00 2001 From: gengjiawen Date: Sat, 2 Mar 2019 21:49:16 +0800 Subject: [PATCH] src: make parameter name const reference in method TriggerNodeReport PR-URL: https://github.com/nodejs/node/pull/26397 Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- src/node_report.cc | 2 +- src/node_report.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_report.cc b/src/node_report.cc index bc54f90d3e73aa..9d676b2d7ad4dc 100644 --- a/src/node_report.cc +++ b/src/node_report.cc @@ -99,7 +99,7 @@ std::string TriggerNodeReport(Isolate* isolate, Environment* env, const char* message, const char* trigger, - std::string name, + const std::string& name, Local stackstr) { std::ostringstream oss; std::string filename; diff --git a/src/node_report.h b/src/node_report.h index 7d36557e669048..7aff7a5e2fa60b 100644 --- a/src/node_report.h +++ b/src/node_report.h @@ -44,7 +44,7 @@ std::string TriggerNodeReport(v8::Isolate* isolate, node::Environment* env, const char* message, const char* trigger, - std::string name, + const std::string& name, v8::Local stackstr); void GetNodeReport(v8::Isolate* isolate, node::Environment* env,