From c8541a7d7a98ca797586d1cf8f528969353d6e75 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 3 Jan 2020 15:21:05 +0100 Subject: [PATCH] build: disable libstdc++ debug containers globally Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: https://github.com/nodejs/node/issues/30056 PR-URL: https://github.com/nodejs/node/pull/30147 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: David Carlier Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: Ruben Bridgewater --- common.gypi | 4 ---- tools/v8_gypfiles/toolchain.gypi | 8 -------- 2 files changed, 12 deletions(-) diff --git a/common.gypi b/common.gypi index ce14757aecdd34..633e99dbbefba1 100644 --- a/common.gypi +++ b/common.gypi @@ -29,10 +29,6 @@ 'openssl_fips%': '', - # Some STL containers (e.g. std::vector) do not preserve ABI compatibility - # between debug and non-debug mode. - 'disable_glibcxx_debug': 1, - # Don't use ICU data file (icudtl.dat) from V8, we use our own. 'icu_use_data_file_flag%': 0, diff --git a/tools/v8_gypfiles/toolchain.gypi b/tools/v8_gypfiles/toolchain.gypi index 264b3e478ef1ba..10709fab1fbc0c 100644 --- a/tools/v8_gypfiles/toolchain.gypi +++ b/tools/v8_gypfiles/toolchain.gypi @@ -64,9 +64,6 @@ # Print to stdout on Android. 'v8_android_log_stdout%': 0, - # Force disable libstdc++ debug mode. - 'disable_glibcxx_debug%': 0, - 'v8_enable_backtrace%': 0, # Enable profiling support. Only required on Windows. @@ -1167,11 +1164,6 @@ # Support for backtrace_symbols. 'ldflags': [ '-rdynamic' ], }], - ['OS=="linux" and disable_glibcxx_debug==0', { - # Enable libstdc++ debugging facilities to help catch problems - # early, see http://crbug.com/65151 . - 'defines': ['_GLIBCXX_DEBUG=1',], - }], ['OS=="aix"', { 'ldflags': [ '-Wl,-bbigtoc' ], 'conditions': [