Skip to content

Commit

Permalink
src: add comment on CallbackScope exception behaviour
Browse files Browse the repository at this point in the history
PR-URL: #21743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
addaleax authored and targos committed Jul 14, 2018
1 parent 0de0f89 commit cb69811
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,10 @@ class InternalCallbackScope;
*
* This object should be stack-allocated to ensure that it is contained in a
* valid HandleScope.
*
* Exceptions happening within this scope will be treated like uncaught
* exceptions. If this behaviour is undesirable, a new `v8::TryCatch` scope
* needs to be created inside of this scope.
*/
class NODE_EXTERN CallbackScope {
public:
Expand Down

0 comments on commit cb69811

Please sign in to comment.