From cc450801096365cd02abd95f5d1a78148cae6eda Mon Sep 17 00:00:00 2001 From: jvelezpo Date: Thu, 9 May 2019 10:07:22 -0500 Subject: [PATCH] doc: dns.lookup() documentation error code dns.lookup() will always return ENOTFOUND on a empty lookup or when the host not found. https://github.com/nodejs/node/blob/master/lib/internal/errors.js#L503 Fixes: https://github.com/nodejs/node/issues/27604 PR-URL: https://github.com/nodejs/node/pull/27625 Reviewed-By: Rich Trott Reviewed-By: James M Snell --- doc/api/dns.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/api/dns.md b/doc/api/dns.md index 22899e625c3f0b..22bca079c3bcf3 100644 --- a/doc/api/dns.md +++ b/doc/api/dns.md @@ -168,7 +168,7 @@ With the `all` option set to `true`, the arguments for `callback` change to properties `address` and `family`. On error, `err` is an [`Error`][] object, where `err.code` is the error code. -Keep in mind that `err.code` will be set to `'ENOENT'` not only when +Keep in mind that `err.code` will be set to `'ENOTFOUND'` not only when the hostname does not exist but also when the lookup fails in other ways such as no available file descriptors. @@ -692,7 +692,7 @@ being an array of objects with the properties `address` and `family`. On error, the `Promise` is rejected with an [`Error`][] object, where `err.code` is the error code. -Keep in mind that `err.code` will be set to `'ENOENT'` not only when +Keep in mind that `err.code` will be set to `'ENOTFOUND'` not only when the hostname does not exist but also when the lookup fails in other ways such as no available file descriptors.