From cef5b1fa145a5f67ae2c9a8c5384705884944a8a Mon Sep 17 00:00:00 2001 From: cjihrig Date: Wed, 9 Nov 2016 10:08:23 -0500 Subject: [PATCH] test: add test for broken child process stdio This commit adds a test for the scenario where a child process is spawned, but the stdio streams could not be created. PR-URL: https://github.com/nodejs/node/pull/9528 Reviewed-By: Daniel Bevenius Reviewed-By: Rich Trott Reviewed-By: Santiago Gimeno Reviewed-By: Michael Dawson --- test/parallel/test-child-process-bad-stdio.js | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 test/parallel/test-child-process-bad-stdio.js diff --git a/test/parallel/test-child-process-bad-stdio.js b/test/parallel/test-child-process-bad-stdio.js new file mode 100644 index 00000000000000..e92bbcf11fbac8 --- /dev/null +++ b/test/parallel/test-child-process-bad-stdio.js @@ -0,0 +1,63 @@ +'use strict'; +// Flags: --expose_internals +const common = require('../common'); +const assert = require('assert'); +const cp = require('child_process'); + +if (process.argv[2] === 'child') { + setTimeout(() => {}, common.platformTimeout(100)); + return; +} + +// Monkey patch spawn() to create a child process normally, but destroy the +// stdout and stderr streams. This replicates the conditions where the streams +// cannot be properly created. +const ChildProcess = require('internal/child_process').ChildProcess; +const original = ChildProcess.prototype.spawn; + +ChildProcess.prototype.spawn = function() { + const err = original.apply(this, arguments); + + this.stdout.destroy(); + this.stderr.destroy(); + this.stdout = null; + this.stderr = null; + + return err; +}; + +function createChild(options, callback) { + const cmd = `${process.execPath} ${__filename} child`; + + return cp.exec(cmd, options, common.mustCall(callback)); +} + +// Verify that normal execution of a child process is handled. +{ + createChild({}, (err, stdout, stderr) => { + assert.strictEqual(err, null); + assert.strictEqual(stdout, ''); + assert.strictEqual(stderr, ''); + }); +} + +// Verify that execution with an error event is handled. +{ + const error = new Error('foo'); + const child = createChild({}, (err, stdout, stderr) => { + assert.strictEqual(err, error); + assert.strictEqual(stdout, ''); + assert.strictEqual(stderr, ''); + }); + + child.emit('error', error); +} + +// Verify that execution with a killed process is handled. +{ + createChild({ timeout: 1 }, (err, stdout, stderr) => { + assert.strictEqual(err.killed, true); + assert.strictEqual(stdout, ''); + assert.strictEqual(stderr, ''); + }); +}