Skip to content

Commit

Permalink
doc: indicate that abort tests do not generate core files
Browse files Browse the repository at this point in the history
The key thing about the tests in `test/abort` is that tests in that
directory do not generate core files (thanks to testcfg.py). Make a note
of that in the test README.

PR-URL: #38422
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
Trott authored and targos committed Jun 11, 2021
1 parent 945450b commit cf0007e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ For the tests to run on Windows, be sure to clone Node.js source code with the

| Directory | Runs on CI | Purpose |
| ---------------- | ---------- | --------------- |
| `abort` | Yes | Tests for when the `--abort-on-uncaught-exception` flag is used. |
| `abort` | Yes | Tests that use `--abort-on-uncaught-exception` and other situations where we want to test something but avoid generating a core file. |
| `addons` | Yes | Tests for [addon](https://nodejs.org/api/addons.html) functionality along with some tests that require an addon. |
| `async-hooks` | Yes | Tests for [async_hooks](https://nodejs.org/api/async_hooks.html) functionality. |
| `benchmark` | Yes | Test minimal functionality of benchmarks. |
Expand Down

0 comments on commit cf0007e

Please sign in to comment.