src: add NOLINT to js_native_.*

* add filter to not lint NOLINT rules PR-URL: #26884 Reviewed-By: Refael Ackermann <refack@gmail.com>
nodejs · Apr 5, 2019 · d0e2650 · d0e2650
1 parent 135b79a
commit d0e2650
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/src/js_native_api.h b/src/js_native_api.h
@@ -1,8 +1,9 @@
 #ifndef SRC_JS_NATIVE_API_H_
 #define SRC_JS_NATIVE_API_H_
 
-#include <stddef.h>
-#include <stdbool.h>
+// This file needs to be compatible with C compilers.
+#include <stddef.h>   // NOLINT(modernize-deprecated-headers)
+#include <stdbool.h>  // NOLINT(modernize-deprecated-headers)
 #include "js_native_api_types.h"
 
 // Use INT_MAX, this should only be consumed by the pre-processor anyway.

diff --git a/src/js_native_api_types.h b/src/js_native_api_types.h
@@ -1,8 +1,11 @@
 #ifndef SRC_JS_NATIVE_API_TYPES_H_
 #define SRC_JS_NATIVE_API_TYPES_H_
 
-#include <stddef.h>
-#include <stdint.h>
+// This file needs to be compatible with C compilers.
+// This is a public include file, and these includes have essentially
+// became part of it's API.
+#include <stddef.h>  // NOLINT(modernize-deprecated-headers)
+#include <stdint.h>  // NOLINT(modernize-deprecated-headers)
 
 #if !defined __cplusplus || (defined(_MSC_VER) && _MSC_VER < 1900)
     typedef uint16_t char16_t;

diff --git a/src/js_native_api_v8.h b/src/js_native_api_v8.h
@@ -1,7 +1,8 @@
 #ifndef SRC_JS_NATIVE_API_V8_H_
 #define SRC_JS_NATIVE_API_V8_H_
 
-#include <string.h>
+// This file needs to be compatible with C compilers.
+#include <string.h>  // NOLINT(modernize-deprecated-headers)
 #include "js_native_api_types.h"
 #include "js_native_api_v8_internals.h"
 

diff --git a/tools/cpplint.py b/tools/cpplint.py
@@ -361,6 +361,7 @@ def GetNonHeaderExtensions():
     '-build/include_subdir',
     '-build/include_what_you_use',
     '-legal/copyright',
+    '-readability/nolint',
     ]
 
 # The default list of categories suppressed for C (not C++) files.