From d17ea8f58487242ce5f77737f170cb66d6f54e1c Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Sun, 1 Dec 2019 01:40:55 +0100 Subject: [PATCH] http2: track nghttp2-allocated memory in heap snapshot PR-URL: https://github.com/nodejs/node/pull/30745 Refs: https://github.com/nodejs/quic/blob/34ee0bc96f804c73cb22b2945a1a78f780938492/src/node_mem.h Refs: https://github.com/nodejs/quic/pull/126 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Rich Trott --- src/node_http2.h | 1 + test/pummel/test-heapdump-http2.js | 1 + 2 files changed, 2 insertions(+) diff --git a/src/node_http2.h b/src/node_http2.h index 1812cba51f4793..07febd7da40a9b 100644 --- a/src/node_http2.h +++ b/src/node_http2.h @@ -792,6 +792,7 @@ class Http2Session : public AsyncWrap, tracker->TrackFieldWithSize("outgoing_storage", outgoing_storage_.size()); tracker->TrackFieldWithSize("pending_rst_streams", pending_rst_streams_.size() * sizeof(int32_t)); + tracker->TrackFieldWithSize("nghttp2_memory", current_nghttp2_memory_); } SET_MEMORY_INFO_NAME(Http2Session) diff --git a/test/pummel/test-heapdump-http2.js b/test/pummel/test-heapdump-http2.js index caece96d01cc72..b3d819edaef91a 100644 --- a/test/pummel/test-heapdump-http2.js +++ b/test/pummel/test-heapdump-http2.js @@ -69,6 +69,7 @@ server.listen(0, () => { { children: [ { node_name: 'Http2Session', edge_name: 'wrapped' }, + { node_name: 'Node / nghttp2_memory', edge_name: 'nghttp2_memory' }, { node_name: 'Node / streams', edge_name: 'streams' }