lib: fix diagnostics_channel hasSubscribers error

Fixes: #36598 PR-URL: #36599 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · Jan 12, 2021 · d20235b · d20235b
1 parent 93237c5
commit d20235b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/diagnostics_channel.js b/lib/diagnostics_channel.js
@@ -8,7 +8,6 @@ const {
   ObjectGetPrototypeOf,
   ObjectSetPrototypeOf,
   SymbolHasInstance,
-  WeakRefPrototypeGet
 } = primordials;
 
 const {
@@ -107,7 +106,7 @@ function channel(name) {
 function hasSubscribers(name) {
   let channel;
   const ref = channels[name];
-  if (ref) channel = WeakRefPrototypeGet(ref);
+  if (ref) channel = ref.get();
   if (!channel) {
     return false;
   }

diff --git a/test/parallel/test-diagnostics-channel-has-subscribers.js b/test/parallel/test-diagnostics-channel-has-subscribers.js
@@ -0,0 +1,10 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const { channel, hasSubscribers } = require('diagnostics_channel');
+
+const dc = channel('test');
+assert.ok(!hasSubscribers('test'));
+
+dc.subscribe(() => {});
+assert.ok(hasSubscribers('test'));