Skip to content

Commit

Permalink
http: move OutboundMessage.prototype.flush to EOL
Browse files Browse the repository at this point in the history
API was deprecated long ago. Move to end of life and remove.

PR-URL: #31164
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
jasnell committed Feb 24, 2020
1 parent e68d4c6 commit d3715c7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 43 deletions.
7 changes: 5 additions & 2 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ However, the deprecation identifier will not be modified.
### DEP0001: `http.OutgoingMessage.prototype.flush`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/31164
description: End-of-Life.
- version:
- v4.8.6
- v6.12.0
Expand All @@ -54,9 +57,9 @@ changes:
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `OutgoingMessage.prototype.flush()` method is deprecated. Use
`OutgoingMessage.prototype.flush()` has been removed. Use
`OutgoingMessage.prototype.flushHeaders()` instead.

<a id="DEP0002"></a>
Expand Down
4 changes: 0 additions & 4 deletions lib/_http_outgoing.js
Original file line number Diff line number Diff line change
Expand Up @@ -900,10 +900,6 @@ OutgoingMessage.prototype.flushHeaders = function flushHeaders() {
this._send('');
};

OutgoingMessage.prototype.flush = internalUtil.deprecate(function() {
this.flushHeaders();
}, 'OutgoingMessage.flush is deprecated. Use flushHeaders instead.', 'DEP0001');

OutgoingMessage.prototype.pipe = function pipe() {
// OutgoingMessage should be write-only. Piping from it is disabled.
this.emit('error', new ERR_STREAM_CANNOT_PIPE());
Expand Down
37 changes: 0 additions & 37 deletions test/parallel/test-http-flush.js

This file was deleted.

0 comments on commit d3715c7

Please sign in to comment.