Skip to content

Commit

Permalink
test: remove common.hasSmallICU
Browse files Browse the repository at this point in the history
common.hasSmallICU is used in only one test and is a one-liner. Move
into the test where it is used to chip away at the `common` monolith.

PR-URL: #22937
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and targos committed Sep 21, 2018
1 parent ace6e07 commit d38ce82
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
5 changes: 0 additions & 5 deletions test/common/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,6 @@ Indicates `hasCrypto` and `crypto` with fips.

Indicates if [internationalization] is supported.

### hasSmallICU
* [&lt;boolean>]

Indicates `hasIntl` and `small-icu` are supported.

### hasIPv6
* [&lt;boolean>]

Expand Down
4 changes: 1 addition & 3 deletions test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ const { fixturesDir } = require('./fixtures');
const tmpdir = require('./tmpdir');
const {
bits,
hasIntl,
hasSmallICU
hasIntl
} = process.binding('config');

const noop = () => {};
Expand Down Expand Up @@ -712,7 +711,6 @@ module.exports = {
hasIntl,
hasCrypto,
hasIPv6,
hasSmallICU,
hasMultiLocalhost,
isAIX,
isAlive,
Expand Down
4 changes: 3 additions & 1 deletion test/parallel/test-icu-data-dir.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
'use strict';
const common = require('../common');
const os = require('os');
if (!(common.hasIntl && common.hasSmallICU))

const { hasSmallICU } = process.binding('config');
if (!(common.hasIntl && hasSmallICU))
common.skip('missing Intl');

const assert = require('assert');
Expand Down

0 comments on commit d38ce82

Please sign in to comment.