Skip to content

Commit

Permalink
test: simplify tests code
Browse files Browse the repository at this point in the history
PR-URL: #28065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
himself65 authored and BridgeAR committed Jun 17, 2019
1 parent f897860 commit d4bb88e
Showing 1 changed file with 9 additions and 20 deletions.
29 changes: 9 additions & 20 deletions test/parallel/test-accessor-properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,27 +33,16 @@ const UDP = internalBinding('udp_wrap').UDP;
}, TypeError);

const StreamWrapProto = Object.getPrototypeOf(TTY.prototype);
const properties = ['bytesRead', 'fd', '_externalStream'];

// Should not throw for Object.getOwnPropertyDescriptor
assert.strictEqual(
typeof Object.getOwnPropertyDescriptor(StreamWrapProto, 'bytesRead'),
'object'
);

assert.strictEqual(
typeof Object.getOwnPropertyDescriptor(StreamWrapProto, 'fd'),
'object'
);

assert.strictEqual(
typeof Object.getOwnPropertyDescriptor(StreamWrapProto, '_externalStream'),
'object'
);

assert.strictEqual(
typeof Object.getOwnPropertyDescriptor(StreamWrapProto, 'fd'),
'object'
);
properties.forEach((property) => {
// Should not throw for Object.getOwnPropertyDescriptor
assert.strictEqual(
typeof Object.getOwnPropertyDescriptor(StreamWrapProto, property),
'object',
'typeof property descriptor ' + property + ' is not \'object\''
);
});

if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
// There are accessor properties in crypto too
Expand Down

0 comments on commit d4bb88e

Please sign in to comment.