Skip to content

Commit

Permalink
benchmark: include ascii to fs/readfile
Browse files Browse the repository at this point in the history
PR-URL: #54988
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
  • Loading branch information
RafaelGSS authored and targos committed Oct 4, 2024
1 parent ce4b6e4 commit d4d5ba3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion benchmark/fs/readFileSync.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const common = require('../common.js');
const fs = require('fs');

const bench = common.createBenchmark(main, {
encoding: ['undefined', 'utf8'],
encoding: ['undefined', 'utf8', 'ascii'],
path: ['existing', 'non-existing'],
hasFileDescriptor: ['true', 'false'],
n: [1e4],
Expand Down
2 changes: 1 addition & 1 deletion benchmark/fs/readfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);

const bench = common.createBenchmark(main, {
duration: [5],
encoding: ['', 'utf-8'],
encoding: ['', 'utf-8', 'ascii'],
len: [1024, 16 * 1024 * 1024],
concurrent: [1, 10],
});
Expand Down

0 comments on commit d4d5ba3

Please sign in to comment.