Skip to content

Commit

Permalink
test: change isAix to isAIX
Browse files Browse the repository at this point in the history
This makes the naming more consistent with existing properties like
isFreeBSD where the capitalization of the property name is consistent
with the conventional styling of the operating system.

PR-URL: #14263
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
  • Loading branch information
LipperZack authored and addaleax committed Jul 24, 2017
1 parent 26785a2 commit d7a1637
Show file tree
Hide file tree
Showing 20 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion test/common/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ the number of calls.

Checks whether free BSD Jail is true or false.

### isAix
### isAIX
* return [&lt;Boolean>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#Boolean_type)

Platform check for Advanced Interactive eXecutive (AIX).
Expand Down
4 changes: 2 additions & 2 deletions test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ exports.PORT = +process.env.NODE_COMMON_PORT || 12346;
exports.isWindows = process.platform === 'win32';
exports.isWOW64 = exports.isWindows &&
(process.env.PROCESSOR_ARCHITEW6432 !== undefined);
exports.isAix = process.platform === 'aix';
exports.isAIX = process.platform === 'aix';
exports.isLinuxPPCBE = (process.platform === 'linux') &&
(process.arch === 'ppc64') &&
(os.endianness() === 'BE');
Expand Down Expand Up @@ -333,7 +333,7 @@ exports.platformTimeout = function(ms) {
if (global.__coverage__)
ms = 4 * ms;

if (exports.isAix)
if (exports.isAIX)
return 2 * ms; // default localhost speed is slower on AIX

if (process.arch !== 'arm')
Expand Down
2 changes: 1 addition & 1 deletion test/known_issues/test-cwd-enoent-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
const common = require('../common');
const assert = require('assert');

if (common.isSunOS || common.isWindows || common.isAix) {
if (common.isSunOS || common.isWindows || common.isAIX) {
// The current working directory cannot be removed on these platforms.
// Change this to common.skip() when this is no longer a known issue test.
assert.fail('cannot rmdir current working directory');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-cwd-enoent-preload.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
// Fails with EINVAL on SmartOS, EBUSY on Windows, EBUSY on AIX.
if (common.isSunOS || common.isWindows || common.isAix)
if (common.isSunOS || common.isWindows || common.isAIX)
common.skip('cannot rmdir current working directory');

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-cwd-enoent-repl.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
// Fails with EINVAL on SmartOS, EBUSY on Windows, EBUSY on AIX.
if (common.isSunOS || common.isWindows || common.isAix)
if (common.isSunOS || common.isWindows || common.isAIX)
common.skip('cannot rmdir current working directory');

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-cwd-enoent.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
// Fails with EINVAL on SmartOS, EBUSY on Windows, EBUSY on AIX.
if (common.isSunOS || common.isWindows || common.isAix)
if (common.isSunOS || common.isWindows || common.isAIX)
common.skip('cannot rmdir current working directory');

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-readfile-pipe-large.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');

// simulate `cat readfile.js | node readfile.js`

if (common.isWindows || common.isAix)
if (common.isWindows || common.isAIX)
common.skip(`No /dev/stdin on ${process.platform}.`);

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-readfile-pipe.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const common = require('../common');

// simulate `cat readfile.js | node readfile.js`

if (common.isWindows || common.isAix)
if (common.isWindows || common.isAIX)
common.skip(`No /dev/stdin on ${process.platform}.`);

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-readfilesync-pipe-large.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const common = require('../common');

// simulate `cat readfile.js | node readfile.js`

if (common.isWindows || common.isAix)
if (common.isWindows || common.isAIX)
common.skip(`No /dev/stdin on ${process.platform}.`);

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-realpath-pipe.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const common = require('../common');

if (common.isWindows || common.isAix)
if (common.isWindows || common.isAIX)
common.skip(`No /dev/stdin on ${process.platform}.`);

const assert = require('assert');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-watch-encoding.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const common = require('../common');
// The testcase makes use of folder watching, and causes
// hang. This behavior is documented. Skip this for AIX.

if (common.isAix)
if (common.isAIX)
common.skip('folder watch capability is limited in AIX.');

const fs = require('fs');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-watch.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class WatchTestCase {
const cases = [
// Watch on a directory should callback with a filename on supported systems
new WatchTestCase(
common.isLinux || common.isOSX || common.isWindows || common.isAix,
common.isLinux || common.isOSX || common.isWindows || common.isAIX,
'watch1',
'foo',
'filePath'
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-os.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const release = os.release();
is.string(release);
assert.ok(release.length > 0);
//TODO: Check format on more than just AIX
if (common.isAix)
if (common.isAIX)
assert.ok(/^\d+\.\d+$/.test(release));

const platform = os.platform();
Expand Down
2 changes: 1 addition & 1 deletion test/pseudo-tty/no_dropped_stdio.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ out += `${'o'.repeat(24)}O`;
setTimeout(function() {
process.stdout.write(out);
process.exit(0);
}, common.isAix ? 200 : 0);
}, common.isAIX ? 200 : 0);
2 changes: 1 addition & 1 deletion test/pseudo-tty/no_interleaved_stdio.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ const err = '__This is some stderr__';
setTimeout(function() {
process.stdout.write(out);
process.stderr.write(err);
}, common.isAix ? 200 : 0);
}, common.isAIX ? 200 : 0);
2 changes: 1 addition & 1 deletion test/pseudo-tty/test-stderr-stdout-handle-sigwinch.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ process.stdout._refreshSize = wrap(originalRefreshSizeStdout,
// can setup the readloop. Provide a reasonable delay.
setTimeout(function() {
process.emit('SIGWINCH');
}, common.isAix ? 200 : 0);
}, common.isAIX ? 200 : 0);
4 changes: 2 additions & 2 deletions test/sequential/test-fs-watch.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const fs = require('fs');
const expectFilePath = common.isWindows ||
common.isLinux ||
common.isOSX ||
common.isAix;
common.isAIX;

let watchSeenOne = 0;
let watchSeenTwo = 0;
Expand Down Expand Up @@ -102,7 +102,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
assert.doesNotThrow(
function() {
const watcher = fs.watch(testsubdir, function(event, filename) {
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
const renameEv = common.isSunOS || common.isAIX ? 'change' : 'rename';
assert.strictEqual(event, renameEv);
if (expectFilePath) {
assert.strictEqual(filename, 'newfile.txt');
Expand Down
2 changes: 1 addition & 1 deletion test/tick-processor/test-tick-processor-builtin.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if (!common.enoughTestCpu)

if (common.isWindows ||
common.isSunOS ||
common.isAix ||
common.isAIX ||
common.isLinuxPPCBE ||
common.isFreeBSD)
common.skip('C++ symbols are not mapped for this os.');
Expand Down
2 changes: 1 addition & 1 deletion test/tick-processor/test-tick-processor-cpp-core.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ if (!common.enoughTestCpu)

if (common.isWindows ||
common.isSunOS ||
common.isAix ||
common.isAIX ||
common.isLinuxPPCBE ||
common.isFreeBSD)
common.skip('C++ symbols are not mapped for this os.');
Expand Down
2 changes: 1 addition & 1 deletion test/tick-processor/test-tick-processor-unknown.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const common = require('../common');
// the full 64 bits and the result is that it does not process the
// addresses correctly and runs out of memory
// Disabling until we get a fix upstreamed into V8
if (common.isAix)
if (common.isAIX)
common.skip('AIX address range too big for scripts.');

if (!common.enoughTestCpu)
Expand Down

0 comments on commit d7a1637

Please sign in to comment.