From d85840dd8fbeffcb31620b39db8f770f84297e18 Mon Sep 17 00:00:00 2001 From: Nikolai Vavilov Date: Mon, 20 Nov 2017 16:56:33 +0200 Subject: [PATCH] doc: require CI status indicator in PRs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commits are often landed despite failing on one or more CI platforms. Having a CI status indicator in the PR should make this less likely to happen. PR-URL: https://github.com/nodejs/node/pull/17151 Reviewed-By: Michaël Zasso Reviewed-By: Joyee Cheung Reviewed-By: Gibson Fahnestock Reviewed-By: Jon Moss Reviewed-By: Tobias Nießen --- COLLABORATOR_GUIDE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index ce43bc208f7d05..9b8140bfea8577 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -142,6 +142,7 @@ test should *fail* before the change, and *pass* after the change. All pull requests that modify executable code should be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). +The pull request should have a CI status indicator if possible. #### Useful CI Jobs