events: no stopPropagation call in cancelBubble

PR-URL: #50405 Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs · Mar 25, 2024 · d9b5cd5 · d9b5cd5
1 parent 6bf148e
commit d9b5cd5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -310,7 +310,7 @@ class Event {
     if (!isEvent(this))
       throw new ERR_INVALID_THIS('Event');
     if (value) {
-      this.stopPropagation();
+      this.#propagationStopped = true;
     }
   }
 

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -738,3 +738,10 @@ let asyncTest = Promise.resolve();
   controller.abort();
   et.dispatchEvent(new Event('foo'));
 }
+
+{
+  const event = new Event('foo');
+  strictEqual(event.cancelBubble, false);
+  event.cancelBubble = true;
+  strictEqual(event.cancelBubble, true);
+}