lib: use internal/url module instead of url

nodejs · Sep 10, 2023 · dad0908 · dad0908
1 parent afea87e
commit dad0908
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/lib/internal/bootstrap/switches/is_main_thread.js b/lib/internal/bootstrap/switches/is_main_thread.js
@@ -290,7 +290,7 @@ rawMethods.resetStdioForTesting = function() {
 // Needed by the module loader and generally needed everywhere.
 require('fs');
 require('util');
-require('url');
+require('internal/url');
 
 require('internal/modules/cjs/loader');
 require('internal/modules/esm/utils');

diff --git a/lib/internal/debugger/inspect_client.js b/lib/internal/debugger/inspect_client.js
@@ -15,7 +15,7 @@ const crypto = require('crypto');
 const { ERR_DEBUGGER_ERROR } = require('internal/errors').codes;
 const { EventEmitter } = require('events');
 const http = require('http');
-const URL = require('url');
+const { URL } = require('internal/url');
 
 const debuglog = require('internal/util/debuglog').debuglog('inspect');
 
@@ -297,7 +297,8 @@ class Client extends EventEmitter {
 
   async _discoverWebsocketPath() {
     const { 0: { webSocketDebuggerUrl } } = await this._fetchJSON('/json');
-    return URL.parse(webSocketDebuggerUrl).path;
+    const { pathname, search } = new URL(webSocketDebuggerUrl);
+    return `${pathname}${search}`;
   }
 
   _connectWebsocket(urlPath) {

diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -95,12 +95,7 @@ const expectedModules = new Set([
   'NativeModule internal/process/pre_execution',
 ]);
 
-if (common.isMainThread) {
-  [
-    'NativeModule internal/idna',
-    'NativeModule url',
-  ].forEach(expectedModules.add.bind(expectedModules));
-} else {
+if (!common.isMainThread) {
   [
     'NativeModule diagnostics_channel',
     'NativeModule internal/abort_controller',