From dbae582b553ddb89b566f02d37e54e3442afd5e0 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 30 Nov 2017 07:46:03 +0100 Subject: [PATCH] test: make CreateParams stack-allocated PR-URL: https://github.com/nodejs/node/pull/17366 Reviewed-By: Anna Henningsen Reviewed-By: Timothy Gu Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis --- test/cctest/node_test_fixture.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cctest/node_test_fixture.h b/test/cctest/node_test_fixture.h index 6ffaf9634973ad..9de8d9e2f62ee2 100644 --- a/test/cctest/node_test_fixture.h +++ b/test/cctest/node_test_fixture.h @@ -59,7 +59,6 @@ class NodeTestFixture : public ::testing::Test { static uv_loop_t* CurrentLoop() { return ¤t_loop; } protected: - v8::Isolate::CreateParams params_; v8::Isolate* isolate_; ~NodeTestFixture() { @@ -71,6 +70,7 @@ class NodeTestFixture : public ::testing::Test { platform_ = new node::NodePlatform(8, ¤t_loop, nullptr); v8::V8::InitializePlatform(platform_); v8::V8::Initialize(); + v8::Isolate::CreateParams params_; params_.array_buffer_allocator = allocator_.get(); isolate_ = v8::Isolate::New(params_); }