From de5c009252d16ec21c1b151355c32a523c3c2099 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 6 May 2023 13:50:44 +0200 Subject: [PATCH] test: adapt test-fs-write to V8 internal changes PR-URL: https://github.com/nodejs/node/pull/49639 Reviewed-By: Jiawen Geng Reviewed-By: Rafael Gonzaga Reviewed-By: Antoine du Hamel --- test/parallel/test-fs-write.js | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js index 59b83f531cf0a6..a4aeb4e16a748f 100644 --- a/test/parallel/test-fs-write.js +++ b/test/parallel/test-fs-write.js @@ -35,13 +35,23 @@ const fn4 = tmpdir.resolve('write4.txt'); const expected = 'ümlaut.'; const constants = fs.constants; -const { externalizeString, isOneByteString } = global; +const { + createExternalizableString, + externalizeString, + isOneByteString, +} = global; // Account for extra globals exposed by --expose_externalize_string. -common.allowGlobals(externalizeString, isOneByteString, global.x); +common.allowGlobals( + createExternalizableString, + externalizeString, + isOneByteString, + global.x, +); { - const expected = 'ümlaut sechzig'; // Must be a unique string. + // Must be a unique string. + const expected = createExternalizableString('ümlaut sechzig'); externalizeString(expected); assert.strictEqual(isOneByteString(expected), true); const fd = fs.openSync(fn, 'w'); @@ -51,7 +61,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x); } { - const expected = 'ümlaut neunzig'; // Must be a unique string. + // Must be a unique string. + const expected = createExternalizableString('ümlaut neunzig'); externalizeString(expected); assert.strictEqual(isOneByteString(expected), true); const fd = fs.openSync(fn, 'w'); @@ -61,7 +72,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x); } { - const expected = 'Zhōngwén 1'; // Must be a unique string. + // Must be a unique string. + const expected = createExternalizableString('Zhōngwén 1'); externalizeString(expected); assert.strictEqual(isOneByteString(expected), false); const fd = fs.openSync(fn, 'w'); @@ -71,7 +83,8 @@ common.allowGlobals(externalizeString, isOneByteString, global.x); } { - const expected = 'Zhōngwén 2'; // Must be a unique string. + // Must be a unique string. + const expected = createExternalizableString('Zhōngwén 2'); externalizeString(expected); assert.strictEqual(isOneByteString(expected), false); const fd = fs.openSync(fn, 'w');